Release prep: fix CLI --version drift + drop dead source maps#26
Merged
Conversation
Release-reviewer findings before the 0.10.0 publish: - CLI --version was hardcoded to 0.9.0 (missed in the version bump). Now read from package.json at runtime so it can never drift again. - sourceMap was on, shipping .js.map files that point at sources not included in the tarball (files: ["dist"]) — dead weight + a minor source-path leak. Turned off in tsconfig.base; example-app is unaffected (it builds --noEmit). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
|
Folded in two fixes from umami's 0.10.0 dogfood verification:
Both rebuilt clean (0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-publish fixes from the release-reviewer pass on 0.10.0.
tutorial-forge --version/tforge --versionreported0.9.0— the literal inmain.tswas missed in the 0.10.0 bump. Now reads frompackage.jsonat runtime (resolves to the package root in bothdistand tsx-run dev), so it can't drift from the published version again.sourceMap: trueemitted.js.mapfiles intodist, whichfiles: ["dist"]then shipped — but no.tssources ship, so the maps were dead weight (and embedded original source paths). Turned off intsconfig.base.json.example-appis unaffected (it builds with--noEmit).Verified: clean rebuild emits 0
.mapfiles,diststill has.js+.d.ts, and the built CLI prints0.10.0.